Backfill fee stats data to make the client compatible with horizon 1.X and 0.X. #2290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Make the client compatible with fee stats data from Horizon 1.X or 0.X.
Why
There are a couple of breaking changes in the Horizon response which we are handling in horizonclient 2.0 in a backward compatibility manner, for example, being able to read a
number
or astring
in some of the response fields. It allows a smooth transition between the new and old versions of Horizon.This PR follows the same approach for fee stats, Horizon is dropping all the
_accepted_fee
fields infee_stats
but instead of adding this breaking change in the next release of the client, we'll make it backward compatible, so people can still usep99_accepted_fields
in their code and have time to upgrade up to horizonclient 3.0.Known limitations
[TODO or N/A]