Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/ingest/ledgerbackend: Add captiveStellarCore tests #2625

Merged
merged 8 commits into from
May 29, 2020

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented May 26, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit refactors captiveStellarCore ledger backend and adds tests.

Close #2585.

Why

stellarCoreRunner has been extracted from captiveStellarCore to allow mocking stellar-core runs. This makes it possible to write tests that do not execute stellar-core binary.

Functions marshalling and unmarshalling framed XDR have been moved to xdr package.

Known limitations

  • This change was added to be able to write any tests. Integration tests should follow at some point in time in the future.

@bartekn bartekn requested a review from a team May 26, 2020 15:11
@cla-bot cla-bot bot added the cla: yes label May 26, 2020
@bartekn bartekn merged commit 05bc2ca into stellar:captive-core May 29, 2020
@bartekn bartekn deleted the captive-stellar-core-runner branch May 29, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants