Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/simplepath: Remove DB path finder. #2663

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jun 4, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Drop DB based path finder.

Why

We have replaced the DB based implementation in favor of the inmemory implementation so we not longer need this code.

This is part of the work to drop db2/core (#2643).

Known limitations

[TODO or N/A]

@abuiles abuiles requested review from bartekn and tamirms June 4, 2020 21:28
@cla-bot cla-bot bot added the cla: yes label Jun 4, 2020
@abuiles abuiles force-pushed the remove-db-path-finder branch from 31ae833 to 204c58b Compare June 4, 2020 21:36
@abuiles abuiles merged commit 27bf500 into stellar:master Jun 4, 2020
@abuiles abuiles deleted the remove-db-path-finder branch June 4, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants