-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon: Remove db2/core. #2759
services/horizon: Remove db2/core. #2759
Conversation
@abuiles can you merge this into |
f6ef87a
to
a5ec40c
Compare
a5ec40c
to
75c16d2
Compare
I was hoping this would remove the requirement of setting a core DB URL (and a core URL) when using captive-core, but I am still getting the following error:
|
|
Addressed at #2780 |
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Remove db2/core.
Why
Horizon shouldn't need access to core's database.
Fix #651.
Known limitations