Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Remove db2/core. #2759

Merged

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jun 29, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove db2/core.

Why

Horizon shouldn't need access to core's database.

Fix #651.

Known limitations

@cla-bot cla-bot bot added the cla: yes label Jun 29, 2020
@abuiles abuiles requested a review from a team June 29, 2020 20:25
services/horizon/internal/init.go Show resolved Hide resolved
@2opremio
Copy link
Contributor

2opremio commented Jun 30, 2020

@abuiles can you merge this into release-horizon-v1.6.0 too? (merging master into release-horizon-v1.6.0 should do)

@abuiles abuiles changed the base branch from master to release-horizon-v1.6.0 June 30, 2020 15:36
@abuiles abuiles force-pushed the remove-core-q-from-app branch 2 times, most recently from f6ef87a to a5ec40c Compare June 30, 2020 15:45
@abuiles abuiles force-pushed the remove-core-q-from-app branch from a5ec40c to 75c16d2 Compare June 30, 2020 16:04
@abuiles abuiles merged commit 81cfb67 into stellar:release-horizon-v1.6.0 Jun 30, 2020
@2opremio
Copy link
Contributor

2opremio commented Jul 1, 2020

I was hoping this would remove the requirement of setting a core DB URL (and a core URL) when using captive-core, but I am still getting the following error:

Invalid config: stellar-core-db-url is blank. Please specify --stellar-core-db-url on the command line or set the STELLAR_CORE_DATABASE_URL environment variable.

@abuiles abuiles deleted the remove-core-q-from-app branch July 1, 2020 15:38
@bartekn
Copy link
Contributor

bartekn commented Jul 1, 2020

--stellar-core-db-url is still required in txsub to submit transactions but we don't need it when not running a webserver (ex. in reingestion context). We should allow empty values when webserver is not running.

#2779

@2opremio
Copy link
Contributor

2opremio commented Jul 2, 2020

Addressed at #2780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizon should not use core db anywhere outside ingest package
4 participants