Merge captive-run-from into master #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use --start-ledger and --start-hash in online captive core. * Fix tests. * Add unit test for runFromParams. * Update ingest/ledgerbackend/captive_core_backend.go Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info> Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info>
…headers (#3156) * historyarchive: Update Archive.GetLedgerHeader to get non-checkpoint headers * Unmarshal to empty object
Previously we were limiting the ledgers where online captive core could start since we were always trying to start (captive core) from the previous check-point ledger. This was probably problematic since this wouldn't work for ledgers smaller than 63.
abuiles
approved these changes
Oct 27, 2020
This was referenced Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge a feature branch implementing run-from more of Stellar-Core.