Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Clean up stellarCoreRunnerFactory #3272

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Dec 8, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

The stellarCoreRunnerFactory function can be simplified by removing the captiveCoreConfigAppendPath string argument. Also, I removed the c.stellarCoreRunner == nil check because it was not necessary.

Known limitations

[N/A]

@cla-bot cla-bot bot added the cla: yes label Dec 8, 2020
c.stellarCoreRunner, err = c.stellarCoreRunnerFactory(stellarCoreRunnerModeOffline, "")
if err != nil {
return errors.Wrap(err, "error creating stellar-core runner")
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessary to check c.stellarCoreRunner == nil because when c.Close() is called a few lines above it sets c.stellarCoreRunner to nil

@tamirms tamirms requested a review from a team December 8, 2020 13:18
@tamirms tamirms marked this pull request as ready for review December 8, 2020 13:20
@tamirms tamirms merged commit f7ed707 into stellar:master Dec 8, 2020
@tamirms tamirms deleted the fix-captive-core-cleanup branch December 8, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants