Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strkey: Check for leftover character to be in the expected alphabet #3529

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Apr 8, 2021

Found this while working on #3527

@2opremio 2opremio requested a review from a team April 8, 2021 11:47
strkey/main.go Outdated Show resolved Hide resolved
@2opremio 2opremio changed the title strkey: Fix potential strkey decoder overflow panic strkey: Check for leftover character to be in the expected alphabet Apr 12, 2021
@2opremio 2opremio force-pushed the prevent-decode-overflow branch from 01e616f to dc835ea Compare April 12, 2021 14:46
@2opremio
Copy link
Contributor Author

@tamirms PTAL

@2opremio 2opremio merged commit 1eb8f04 into stellar:master Apr 12, 2021
@2opremio 2opremio deleted the prevent-decode-overflow branch April 12, 2021 17:51
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! One request below.

strkey/main.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants