Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add --skip-migrations-check flag #3557

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Apr 21, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit adds --skip-migrations-check flag that, when set, will skip checking if there are any migrations required to start Horizon.

Why

When checking if there are any migrations required Horizon calls migrate.PlanMigration which sends CREATE TABLE gorp_migrations. This query is forbidden when using read only database (like replica).

Known limitations

No tests, will be added in #3193.

@bartekn bartekn requested a review from a team April 21, 2021 12:02
@bartekn bartekn merged commit 7c92b23 into stellar:master Apr 21, 2021
@bartekn bartekn deleted the horizon-skip-migrations-check branch April 21, 2021 12:28
bartekn added a commit that referenced this pull request Apr 23, 2021
This commit adds `--skip-migrations-check` flag that, when set, will skip
checking if there are any migrations required to start Horizon.

When checking if there are any migrations required Horizon calls
`migrate.PlanMigration` which sends `CREATE TABLE gorp_migrations`. This query
is forbidden when using read only database (like replica).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants