Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support/db: Handle "conflict with recovery" errors gracefully #3674

Merged
merged 1 commit into from
Jun 10, 2021
Merged

support/db: Handle "conflict with recovery" errors gracefully #3674

merged 1 commit into from
Jun 10, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jun 8, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

This commit returns ErrConflictWithRecovery error in case of Postgres canceling statement due to conflict with recovery error and handles this error in Horizon.

@bartekn bartekn requested a review from a team June 8, 2021 15:59
@bartekn bartekn merged commit 7bdf15b into stellar:master Jun 10, 2021
@bartekn bartekn deleted the recovery-conflict-error branch June 10, 2021 13:53
@bartekn bartekn mentioned this pull request Jun 29, 2021
Merged
7 tasks
bartekn added a commit that referenced this pull request Jun 30, 2021
@bartekn
services/horizon: Fix remaining HTTP error logging (#3730)
3f55f73 
In #3674 `canceling statement due to conflict with recovery` errors were
silenced so Horizon does not report expected errors with `level=error`. However,
`bad connection` errors that occur from time to time (around 0.001% of all
requests in the last 24h in horizon.stellar.org likely after conflict with
recovery error) were missed but trigger alerts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartekn @tamirms