Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix data races found by integration tests #3690

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jun 14, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

This commit adds -race flag to Horizon integration tests and fixes two bugs found by race detector:

  • Client.sendRequest overwriting c.HorizonURL when used in multiple go routines.
  • decoder.IgnoreUnknownKeys overwriting gorilla/schema.Decoder.ignoreUnknownKeys when called from multiple go routines.

@bartekn bartekn requested a review from a team June 14, 2021 21:44
@bartekn bartekn added this to the Horizon 2.5.0 milestone Jun 14, 2021
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that it caught this!

@@ -26,8 +26,8 @@ import (

// sendRequest builds the URL for the given horizon request and sends the url to a horizon server
func (c *Client) sendRequest(hr HorizonRequest, resp interface{}) (err error) {
c.HorizonURL = c.fixHorizonURL()
req, err := hr.HTTPRequest(c.HorizonURL)
horizonURL := c.fixHorizonURL()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment is in order here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to update the horizonclient release notes as well

@bartekn
Copy link
Contributor Author

bartekn commented Jun 15, 2021

@2opremio @tamirms Switched to sync.Once and updated CHANGELOG.

@bartekn bartekn merged commit 55f106c into stellar:release-horizon-v2.5.0 Jun 15, 2021
@bartekn bartekn deleted the fix-data-race-bugs-integration-tests branch June 15, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants