-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txnbuild: adds a 5 minute grace period to ReadChallengeTx MinTime constraint #3824
txnbuild: adds a 5 minute grace period to ReadChallengeTx MinTime constraint #3824
Conversation
c5be599
to
4de8287
Compare
I had originally created my feature branch on |
@ire-and-curses I'm not sure who should review this so feel free to add someone and remove yourself 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good. 👏🏻 We could also make it configurable, but there's no rush to do that now and we can always expose the config later if needed. There's value in making this configurable in SDKs that are used with clients and servers, but less so with servers.
@JakeUrban This change is not breaking and you could have it target |
bfd1043
to
5b2b40b
Compare
I force pushed to rebase on master, no changes to the code though. |
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Adds a 5 minute grace period to
ReadChallengeTx
'sTransaction.Timebounds().MinTime
constraint to account for clock drift between the client and server.Why
The JS SDK recently merged a similar change (commit), which is now requested for the Go SDK (issue).
Known limitations
N/A