Add stellar/go-xdr#16 (reduction on XDR encoding/decoding allocations) #4042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates stellar/go-xdr#16 in Horizon.
The benchmarks (copied from stellar/xdrgen#65 but using a larger transaction) show a big improvement in the allocations made by the encoder/decoder.
Before:
After:
Note how the allocations go down:
This should relieve a lot of pressure in the garbage collector ( #4022 shows how allocations/garbage collection constitute a big part of Horizon's runtime)