Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Update 51_remove_ht_unused_indexes.sql to drop index IF EXISTS #4089

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Nov 18, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update the latest migration in master to drop index IF EXISTS.

Why

I already suggested some Horizon admins to drop the unused indexes for performance reasons so the migration would fail for them.

Known limitations

[TODO or N/A]

@bartekn bartekn requested a review from 2opremio November 18, 2021 13:24
@bartekn bartekn requested a review from a team November 18, 2021 21:57
@bartekn bartekn merged commit 1ef6e94 into stellar:master Nov 19, 2021
@bartekn bartekn deleted the drop-index-if-exists branch November 19, 2021 11:11
erika-sdf pushed a commit to erika-sdf/go that referenced this pull request Dec 3, 2021
…x IF EXISTS (stellar#4089)

Update the latest migration in master to drop index `IF EXISTS`.

I already suggested some Horizon admins to drop the unused indexes for
performance reasons so the migration would fail for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants