exp/orderbook: Micro-optimization for paths search #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leftover from stellar#4105
tamirms
approved these changes
Dec 3, 2021
| @@ -423,7 +423,7 @@ func (graph *OrderBookGraph) FindFixedPaths( | |||
| maxAssetsPerPath int, | |||
| includePools bool, | |||
| ) ([]Path, uint32, error) { | |||
| target := map[int32]bool{} | |||
| target := make(map[int32]bool, len(destinationAssets)) | |||
| for _, destinationAsset := range destinationAssets { | |||
| destinationAssetString := destinationAsset.String() | |||
| target[graph.assetStringToID[destinationAssetString]] = true | |||
There was a problem hiding this comment.
If this map is being used as a set where every entry has a value of true, there might also be a gain in converting the type to map[int32]struct{} since an empty struct consumes no memory while a book does. Not sure if the gain will be meaningful, but mentioning just in case.
https://dave.cheney.net/2014/03/25/the-empty-struct
There was a problem hiding this comment.
Actually, for maps this might actually result in more allocations 🤔 TIL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover from #4105
I just found it in a local branch and I realized I forgot to push it.
Very very minor stuff.