exp/services/market-tracker: fix go mod errors #4136
Merged
+514
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Update the stellar/go dependency.
Why
On two occassions the go.mod file in the market-tracker folder has caused errors in things I've been doing (snyk security scanning, and using goland). The cause is the old version of stellar/go because depends on a package that was never cached in the go proxy and was removed from bitbucket when bitbucket delete all its mercurial projects.
There's no major problem here, it's just annoying to see errors about something that is not particularly important to us right now.
I'm not sure what the long term plans are with this module, but a quick fix of the problem at hand is just to upgrade stellar/go to a version where that dependency isn't used anymore.
Known limitations
N/A