Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/services/market-tracker: fix go mod errors #4136

Merged
merged 3 commits into from
Dec 15, 2021
Merged

exp/services/market-tracker: fix go mod errors #4136

merged 3 commits into from
Dec 15, 2021

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Dec 9, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update the stellar/go dependency.

Why

On two occassions the go.mod file in the market-tracker folder has caused errors in things I've been doing (snyk security scanning, and using goland). The cause is the old version of stellar/go because depends on a package that was never cached in the go proxy and was removed from bitbucket when bitbucket delete all its mercurial projects.

There's no major problem here, it's just annoying to see errors about something that is not particularly important to us right now.

I'm not sure what the long term plans are with this module, but a quick fix of the problem at hand is just to upgrade stellar/go to a version where that dependency isn't used anymore.

Known limitations

N/A

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
987Nabil Nabil Abdel-Hafeez

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@leighmcculloch leighmcculloch enabled auto-merge (squash) December 15, 2021 19:12
@leighmcculloch leighmcculloch merged commit e946310 into stellar:master Dec 15, 2021
@leighmcculloch leighmcculloch deleted the remove-warnings-on-old-proj branch December 15, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants