Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/horizon: add missing strkey type names. #4429

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Jun 9, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

fix #4428

Why

see #4428

Known limitations

N/A

strkey.VersionByteHashTx: "preauth_tx",
strkey.VersionByteAccountID: "ed25519_public_key",
strkey.VersionByteSeed: "ed25519_secret_seed",
strkey.VersionByteMuxedAccount: "muxed_account",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if VersionByteMuxedAccount key ever appears in horizon responses.

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you! 👏

@Shaptic Shaptic merged commit b29a93b into stellar:master Jun 14, 2022
@overcat overcat deleted the fix-4428 branch July 29, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horizon: /accounts/{account_id} shows the ed25519_signed_payload signer type as unknown
2 participants