Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncup with master #4874

Merged

Conversation

tsachiherman
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update the soroban-xdr-next with the changes that have been merged into main.

Why

We want the releases to be identical, with the exception of the soroban support.

Known limitations

N/A

@tsachiherman tsachiherman requested a review from sreuland May 5, 2023 17:21
@tsachiherman tsachiherman self-assigned this May 5, 2023
@tsachiherman tsachiherman merged commit ca711a9 into stellar:soroban-xdr-next May 11, 2023
@tsachiherman tsachiherman deleted the tsachi/syncwithmaster branch May 11, 2023 21:38
@tsachiherman tsachiherman restored the tsachi/syncwithmaster branch May 15, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants