Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Update default for --captive-core-use-db to true #4877

Merged
merged 2 commits into from
Jun 6, 2023
Merged

services/horizon: Update default for --captive-core-use-db to true #4877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f3271
4856: Update default for --captive-core-use-db to true
urvisavla May 19, 2023
029c169
Update CHANGELOG.md
urvisavla Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions services/horizon/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ file. This project adheres to [Semantic Versioning](http://semver.org/).


## Unreleased
### Changes
### Breaking Changes
- Modify the default value of `--captive-core-use-db` to true ([4856](https://github.com/stellar/go/issues/4856))
- This updates the default behavior of captive core to start in on-disk mode.
- To continue using the previous in-memory mode, explicitly set the `--captive-core-use-db` flag to false

## 2.24.1

Expand Down
5 changes: 1 addition & 4 deletions services/horizon/internal/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func Flags() (*Config, support.ConfigOptions) {
&support.ConfigOption{
Name: CaptiveCoreConfigUseDB,
OptType: types.Bool,
FlagDefault: false,
FlagDefault: true,
Required: false,
Usage: `when enabled, Horizon ingestion will instruct the captive
core invocation to use an external db url for ledger states rather than in memory(RAM).\n
Expand Down Expand Up @@ -736,9 +736,6 @@ func ApplyFlags(config *Config, flags support.ConfigOptions, options ApplyOption
if config.StellarCoreDatabaseURL != "" {
return fmt.Errorf("Invalid config: --%s passed but --ingest not set. ", StellarCoreDBURLFlagName)
}
if config.CaptiveCoreConfigUseDB {
return fmt.Errorf("Invalid config: --%s has been set, but --ingest not set. ", CaptiveCoreConfigUseDB)
}
}

// Configure log file
Expand Down