Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse LIMIT_TX_QUEUE_SOURCE_ACCOUNT in core config #4912

Merged

Conversation

mollykarcher
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Porting this change #4882 from soroban-xdr-next into master.

Why

Core wants to be able to release the 1 transaction/account/ledger restriction ahead of when it is forced by protocol 20, to observe any fallout independent of soroban. Their high-level plan is referenced here

Known limitations

[TODO or N/A]

@tsachiherman
Copy link
Contributor

Fyi: #4882

@mollykarcher
Copy link
Contributor Author

Fyi: #4882

Yep, referenced this in PR description. This is just porting that back to master branch

@mollykarcher mollykarcher merged commit 01c7aa3 into stellar:master Jun 16, 2023
@mollykarcher mollykarcher deleted the molly/main/limit-act-tx-ledger branch June 16, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants