Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add hash to the txsub timeout response #5328

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented May 31, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

  • Change the txsub timeout description to suggest polling the GET endpoint instead of resubmission.
  • Add the transaction hash to the response

Why

We want users to favor polling instead of resubmitting on a timeout. This is because the 504 Timeout does not necessarily mean the transaction has failed and resubmission can lead to tx_bad_seq errors, which has happened with horizon operators before.

Known limitations

NA

@aditya1702 aditya1702 requested a review from JakeUrban May 31, 2024 18:02
@aditya1702 aditya1702 marked this pull request as ready for review May 31, 2024 18:02
@aditya1702 aditya1702 requested review from Shaptic and tamirms May 31, 2024 18:05
@aditya1702 aditya1702 requested a review from JakeUrban May 31, 2024 19:28
@aditya1702 aditya1702 changed the title services/horizon: Change the txsub timeout response services/horizon: Add hash to the txsub timeout response Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants