Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Add prometheus metrics to track captive core startup time #5449

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Aug 30, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Close #5417

This PR adds two prometheus metrics to captive core:

  1. A counter which increments whenever we need to run captive core on a clean db instead of resuming from the LCL of the previous run
  2. A summary which measures the amount of seconds it takes for captive core to emit its first ledger when preparing an unbounded range

These two metrics will give us insight into how often we run into #5123

Why

See #5417 for motivation

Known limitations

[N/A]

@tamirms tamirms marked this pull request as ready for review August 30, 2024 09:33
@tamirms tamirms requested a review from a team August 30, 2024 10:32
@tamirms tamirms merged commit 61bbeb8 into stellar:master Sep 3, 2024
23 checks passed
@tamirms tamirms deleted the core-startup-time-metric branch September 3, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Horizon metric for keeping track of slow ingestion restarts
2 participants