Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error if you try to sign transactions that need contract signatures. #576

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Throw error if you try to sign transactions that need contract signatures. #576

merged 2 commits into from
Feb 14, 2023

Conversation

paulbellamy
Copy link
Contributor

I spent a while debugging this, and an error here would have helped me.

For some reason this test says that [].some() doesn't exist, though.. cc @Shaptic ?

@Shaptic Shaptic changed the title Attempting to add an error if you try to sign a transaction that needs contract signatures Throw error if you try to sign transactions that need contract signatures. Feb 14, 2023
@paulbellamy paulbellamy merged commit 123279a into soroban Feb 14, 2023
@paulbellamy paulbellamy deleted the soroban-error-on-contract-signatures branch February 14, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbellamy @Shaptic