Upgrades the Soroban XDR to the latest version. #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
requested review from
paulbellamy,
willemneal,
2opremio,
sreuland and
a team
Shaptic
commented
Aug 4, 2023
|
Size Change: -3.75 kB (0%) Total Size: 3.07 MB
|
sreuland
reviewed
Aug 5, 2023
| expect(args.length).to.equal(1); | ||
| expect(entry.rootInvocation()).to.eql(invocation); | ||
|
|
||
| // sanity check raw xdr signature types: should be ScVal{ |
There was a problem hiding this comment.
not suggesting any change, since mostly defined the expected outcome as xdr js object here, would using that as expect(sig).to.equal(expectedXdrSig) be a substitute instead of multiple lower level verification checks, and then the code becomes the docs rather than maintaining over time, which is great that it's here in any case for those less in tune like myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655.