Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the return type of walkInvocationTree's callback to allow void returns as intended #765

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jul 26, 2024

No description provided.

Copy link

github-actions bot commented Jul 26, 2024

Size Change: +39.5 kB (+1.23%)

Total Size: 3.25 MB

Filename Size Change
dist/stellar-base.js 2.39 MB +29.9 kB (+1.27%)
dist/stellar-base.min.js 867 kB +9.6 kB (+1.12%)

compressed-size-action

@sreuland
Copy link
Contributor

changes look good, can approve, but for consideration, wondering if it's time to introduce ts test to assert these will work from client before releasing, same observation noted on https://github.com/stellar/js-stellar-base/pull/766/files#r1729557085

@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 27, 2024

@sreuland good suggestion 🙏 generally the type tests don't help much but you can see in 580b2b8 that this actually uncovered the fact that there is in fact a void return value (rather than undefined) which is great 👏 please review again!

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work!

@Shaptic Shaptic merged commit 83c4960 into master Sep 12, 2024
8 checks passed
@Shaptic Shaptic deleted the void-return branch September 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants