-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction_id
to SEP-12 requests
#134
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,13 +26,16 @@ internal constructor( | |
* @param type (optional) the type of action the customer is being KYCd for. | ||
* @param lang (optional) Defaults to en. Language code specified using ISO 639-1. Human-readable | ||
* descriptions, choices, and messages should be in this language. | ||
* @param transactionId (optional) the ID of the transaction that the customer is being KYC'ed | ||
* for. | ||
* @return a customer data object | ||
*/ | ||
suspend fun get( | ||
id: String? = null, | ||
memo: ULong? = null, | ||
type: String? = null, | ||
lang: String? = null, | ||
transactionId: String? = null, | ||
): GetCustomerResponse { | ||
validateMemo(memo) | ||
|
||
|
@@ -42,6 +45,7 @@ internal constructor( | |
urlBuilder.addParameter("memo", memo?.toString()) | ||
urlBuilder.addParameter("type", type) | ||
urlBuilder.addParameter("lang", lang) | ||
urlBuilder.addParameter("transaction_id", transactionId) | ||
val urlString = urlBuilder.buildString() | ||
|
||
val response = httpClient.authGet<GetCustomerResponse>(urlString, token) | ||
|
@@ -69,19 +73,23 @@ internal constructor( | |
* @param memo (optional) the client-generated memo of type ID that uniquely identifies the | ||
* customer. If a memo is present in the decoded SEP-10 JWT's sub value, it must match this | ||
* parameter value. | ||
* @param transactionId (optional) the ID of the transaction that the customer is being KYC'ed | ||
* for. | ||
* @return a customer with id information | ||
*/ | ||
suspend fun add( | ||
sep9Info: Map<String, String>, | ||
memo: ULong? = null, | ||
type: String? = null, | ||
transactionId: String? = null, | ||
): AddCustomerResponse { | ||
val customer: MutableMap<String, String> = mutableMapOf() | ||
|
||
populateMap(type, customer, memo, sep9Info) | ||
|
||
val urlBuilder = URLBuilder(baseUrl) | ||
urlBuilder.appendPathSegments("customer") | ||
urlBuilder.addParameter("transaction_id", transactionId) | ||
val urlString = urlBuilder.buildString() | ||
|
||
return httpClient.putJson(urlString, customer.toMap(), token) | ||
|
@@ -98,13 +106,16 @@ internal constructor( | |
* @param memo (optional) the client-generated memo of type ID that uniquely identifies the | ||
* customer. If a memo is present in the decoded SEP-10 JWT's sub value, it must match this | ||
* parameter value. | ||
* @param transactionId (optional) the ID of the transaction that the customer is being KYC'ed | ||
* for. | ||
* @return a customer with id information | ||
*/ | ||
suspend fun update( | ||
sep9Info: Map<String, String>, | ||
id: String, | ||
type: String? = null, | ||
memo: ULong? = null, | ||
transactionId: String? = null, | ||
): AddCustomerResponse { | ||
val customer: MutableMap<String, String> = mutableMapOf("id" to id) | ||
|
||
|
@@ -116,6 +127,7 @@ internal constructor( | |
|
||
val urlBuilder = URLBuilder(baseUrl) | ||
urlBuilder.appendPathSegments("customer") | ||
urlBuilder.addParameter("transaction_id", transactionId) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @philipliu @Ifropc same question here: shouldn't the |
||
val urlString = urlBuilder.buildString() | ||
|
||
return httpClient.putJson(urlString, customer.toMap(), token) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipliu @Ifropc shouldn't the
transaction_id
value go in the requestbody
(aka populateMap) instead of a url parameter for thisPUT
request?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. I'll publish a PR to fix this.