Account: Saved Keypairs #1138
Account: Saved Keypairs #1138
Conversation
quietbits
commented
Nov 6, 2024
•
quietbits
commented
|
Preview is available here: |
|
@quietbits On the Save Keypair page, should we follow the same pattern as on the Create Account Keypair page and hide the secret key as ********. What do you think? Separately, when my mouse hovers over the public key, my cursor turns to this 🚫 . I think it should be the same as the Create Account Keypair page. |
@janewang , yes, we can mask the secret key. 👍
The input fields are disabled, that's why you see the 🚫 icon on hover. We can change that to read-only, but the design has the disabled style. It's an easy update.
|
I think the design should be consistent in saved keypairs and in create keypairs. Thank you for the update! |
|
Preview is available here: |
|
Preview is available here: |
|
Preview is available here: |
|
I think we should reset the mainnet-to-futurenet.mov |
|
|
| import { NetworkType, SavedKeypair } from "@/types/types"; | ||
| import { arrayItem } from "@/helpers/arrayItem"; | ||
|
|
||
| export default function SavedKeypairs() { |
There was a problem hiding this comment.
curious - when should we use export default function vs. export const. in vibrant days, we preferred using const for exporting vs. default (product convention).
There was a problem hiding this comment.
(I am not suggesting that we follow the convention btw, I'm just curious)
| getNetworkById(newNetworkId); | ||
| }} | ||
| > | ||
| {`You must switch your network to ${otherNetworkLabel} in order to see those saved |
There was a problem hiding this comment.
can we just do the following?
You must switch your network to {otherNetworkLabel} in order to see those saved keypairs. This feature is only available on Futurenet and Testnet for security reasons.
There was a problem hiding this comment.
Yes, that works, too. In cases like this, I prefer formatting it as a string because it's more clear and consistent in the code editor what it is. This is just my preference, nothing else. 😊 If you feel strongly about it, I can update it.
vs
| <Text | ||
| as="div" | ||
| size="xs" | ||
| >{`Last saved ${formatTimestamp(timestamp)}`}</Text> |
There was a problem hiding this comment.
can we do Last saved {formatTimestamp(timestamp)} instsead?
Good idea, we should reset the keypair when the network changes. Issue created. |
Good catch! 🙌 We have two types of headings throughout the app. I started a Slack thread to see how we want to handle them. |
|
Preview is available here: |
