Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Updates for /assets and /claimable_balances/*/(operations|transactions) endpoints #373

Merged
merged 5 commits into from
May 11, 2021

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Apr 1, 2021

Not sure about wording and phrasing really. Mostly just copied from existing docs.

TODO

  • Figure out a shorter name for the claimable balance menu names, so it doesn't overflow the menu.
  • Do the js sdk updates and get those merged first.

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But won't merge until the SDK work gets in 👍

@Shaptic
Copy link
Contributor

Shaptic commented Apr 7, 2021

Also agreed re: title naming. Maybe just "Listing Relevant [Transactions|Operations]"? Will defer to you, but I do think it's worth making it shorter to avoid overflow.

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@paulbellamy paulbellamy marked this pull request as ready for review May 11, 2021 19:00
@Shaptic Shaptic merged commit 687f016 into stellar:master May 11, 2021
@paulbellamy paulbellamy deleted the assets-updates branch May 24, 2021 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants