This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 132
Updates for /assets and /claimable_balances/*/(operations|transactions) endpoints #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview is available here: |
This was referenced Apr 6, 2021
paulbellamy
force-pushed
the
assets-updates
branch
from
April 7, 2021 13:26
57a7392
to
c52b272
Compare
Preview is available here: |
Shaptic
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But won't merge until the SDK work gets in 👍
Also agreed re: title naming. Maybe just "Listing Relevant [Transactions|Operations]"? Will defer to you, but I do think it's worth making it shorter to avoid overflow. |
Preview is available here: |
Preview is available here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about wording and phrasing really. Mostly just copied from existing docs.
TODO