-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve storage errors #1008
Comments
CC @dmkozh |
I have seen that I can recover diagnostic events in But even then, the diagnostic events are not useful. Here's the XDR of the only event returned:
|
Hi @2opremio, Can you re-evaluate this with latest preview 11 build, please. |
This can be closed since we are have lot of improved error handling. Please open a new issue if there are any other areas we can improve. |
When calling
host.invoke_function()
, if a ledger entry is missing (e.g. due to a badly constructed contract invocation), the following error message is returned:(note that this is before invoking
host.try_finish()
and thus there are no diagnostic events).I would expect the error to tell me the key of the missing ledger entry. Also,
(Storage, MissingValue)
isn't helpful since it doesn't tell the user it's a LedgerEntry which is missing.In general, I think any errors returned by
host.invoke_function()
beforetry_finish()
should be descriptive and add context, since there are no diagnostic events.The text was updated successfully, but these errors were encountered: