soroban-rpc: simulateTransaction: try to return diagnostic events on failure #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
requested review from
paulbellamy,
Shaptic,
willemneal and
tsachiherman
2opremio
changed the title
|
I have another PR that is targeting the current futurenet branch: AhaLabs#8 But it should log all simulation events. |
Shaptic
approved these changes
Aug 21, 2023
tsachiherman
suggested changes
Aug 21, 2023
2opremio
force-pushed
the
also-return-events-on-failure
branch
from
ad63115
to
53021ae
Compare
tsachiherman
approved these changes
Aug 21, 2023
This was referenced Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if
host.invoke_host_function()fails, leading to an error, we can collect and return diagnostic events.Note that this implies that the events field of the simulate transaction response can be set when an error is returned.
Also, sneak in some review feedback from #875 which I incorrectly pushed to this branch (sorry @tsachiherman )
(Found out about it in stellar/rs-soroban-env#1008 ).
@willemneal we should probably do the same in the CLI's snapshot mode (in case we don't do it already).