Allow passing the setting for non-root auth to the simulation. #1503
+120
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unfortunately a breaking change and thus it needs to be guarded by unstable-next-api feature.
sisuresh
reviewed
Dec 24, 2024
| @@ -122,7 +123,7 @@ pub fn simulate_invoke_host_function_op( | |||
| adjustment_config: &SimulationAdjustmentConfig, | |||
| ledger_info: &LedgerInfo, | |||
| host_fn: HostFunction, | |||
| auth_entries: Option<Vec<SorobanAuthorizationEntry>>, | |||
| auth_mode: RecordingInvocationAuthMode, | |||
There was a problem hiding this comment.
Does this not need to be behind the unstable-next-api flag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow passing the setting for non-root auth to the simulation.
This is unfortunately a breaking change and thus it needs to be guarded by unstable-next-api feature.
Why
This allows for more control over the simulation logic - while the default is sufficient 99% of the time, there is still 1% of the cases where non-root auth should be allowed.
Known limitations
N/A