Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stellar-xdr and get BytesM/StringM #536

Merged
merged 7 commits into from
Oct 13, 2022
Merged

Update stellar-xdr and get BytesM/StringM #536

merged 7 commits into from
Oct 13, 2022

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 12, 2022 •
edited
Loading

What

Update stellar-xdr and get BytesM/StringM types.

Why

See stellar/xdrgen#143

Close stellar/xdrgen#125
Close stellar/xdrgen#119
Close stellar/xdrgen#118

graydon
graydon approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leighmcculloch leighmcculloch marked this pull request as ready for review October 13, 2022 03:50
@leighmcculloch leighmcculloch requested review from sisuresh and a team as code owners October 13, 2022 03:50
@leighmcculloch leighmcculloch enabled auto-merge (squash) October 13, 2022 03:50
@leighmcculloch leighmcculloch merged commit 4f2f3a2 into main Oct 13, 2022
@leighmcculloch leighmcculloch deleted the experiment-with-bytesm branch October 13, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graydon graydon graydon approved these changes

@sisuresh sisuresh Awaiting requested review from sisuresh sisuresh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leighmcculloch @graydon