Split out `DeclaredSizeForMetering` from `MeteredClone` and use it for `Compare` #714

jayz22 · 2023-02-28T04:25:17Z

What

Resolves #605.
It splits out the DeclaredSizeForMetering from MeteredClone (previously defined as MeteredClone::ELT_SIZE) out of metered clone and share it between clone and comparison.
Adapt to the object overahaul, which introduced many new types. Declared all the RawVal-wrapping types to be fixed size.
Fix try_compare_to_small to use metered compare.

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

…r`Compare` metering

soroban-env-host/src/host/declared_size.rs

soroban-env-host/src/host/metered_map.rs

soroban-env-host/src/host/metered_vector.rs

soroban-env-host/src/host/declared_size.rs

graydon

Looks pretty good! handful of nits

jayz22 force-pushed the fixed-size-ord branch from a852577 to b64eab6 Compare March 2, 2023 02:58

jayz22 changed the title ~~(Not working) Split fixed sized type and share between clone and cmp~~ Split out DeclaredSizeForMetering from MeteredClone and use it for Compare Mar 2, 2023

jayz22 marked this pull request as ready for review March 2, 2023 03:02

jayz22 requested review from graydon and sisuresh as code owners March 2, 2023 03:02

jayz22 added 2 commits March 9, 2023 19:36

Split out DeclaredSizeForMetering from MeteredClone and use it fo…

0b04c24

…r`Compare` metering

Adapt new types to metered compare

6ecf417

jayz22 force-pushed the fixed-size-ord branch from b64eab6 to 6ecf417 Compare March 10, 2023 17:37

jayz22 requested a review from a team as a code owner March 10, 2023 17:37