Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose secp256k1 and keccak256 in the SDK #1028

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

masonforest
Copy link
Contributor

@masonforest masonforest commented Jun 30, 2023

What

Expose secp256k1 and keccak256 in the SDK.

Why

secp256k1 is a widely used cryptographic signature algorithm and keccak256 is a widely used hashing algorithm. Exposing these functions will allow smart contract developers to utilize these algorithms in their applications without having to implement them themselves.

Follow on work

  • Pending this discussion on best practices I will call check_env where applicable.

Known limitations

N/A

Github Issue: surface new crypto functions in SDK

@masonforest masonforest force-pushed the add-keccak256-and-secp256k1 branch from 452d184 to a567261 Compare September 18, 2023 12:40
@masonforest masonforest force-pushed the add-keccak256-and-secp256k1 branch 3 times, most recently from 9d88390 to b22a1ec Compare September 18, 2023 12:52
@masonforest masonforest force-pushed the add-keccak256-and-secp256k1 branch from b22a1ec to 2458c95 Compare September 18, 2023 12:53
…th ed25519_verify, used BytesN for all fixed length values, replaced checked conversion with unchecked conversion where safe, removed use of U32Val in dev facing api
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masonforest! I pushed a few minor tweaks.

@leighmcculloch leighmcculloch added this pull request to the merge queue Sep 18, 2023
@leighmcculloch leighmcculloch removed this pull request from the merge queue due to a manual request Sep 18, 2023
@leighmcculloch leighmcculloch added this pull request to the merge queue Sep 18, 2023
Merged via the queue into stellar:main with commit b5cc44a Sep 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants