Expose secp256k1 and keccak256 in the SDK
#1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
masonforest
force-pushed
the
add-keccak256-and-secp256k1
branch
from
452d184 to
a567261
Compare
masonforest
force-pushed
the
add-keccak256-and-secp256k1
branch
3 times, most recently
from
9d88390 to
b22a1ec
Compare
masonforest
force-pushed
the
add-keccak256-and-secp256k1
branch
from
b22a1ec to
2458c95
Compare
…th ed25519_verify, used BytesN for all fixed length values, replaced checked conversion with unchecked conversion where safe, removed use of U32Val in dev facing api
leighmcculloch
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Expose
secp256k1andkeccak256in the SDK.Why
secp256k1is a widely used cryptographic signature algorithm andkeccak256is a widely used hashing algorithm. Exposing these functions will allow smart contract developers to utilize these algorithms in their applications without having to implement them themselves.Follow on work
Pending this discussion on best practices I will callcheck_envwhere applicable.Known limitations
N/A
Github Issue: surface new crypto functions in SDK