Bump env crate dep and use separate rev for macro XDR dep #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
bump-env-and-separate-xdr-dependency-version
branch
from
9ac90d1 to
bd7e451
Compare
jonjove
approved these changes
Jun 27, 2022
graydon
force-pushed
the
bump-env-and-separate-xdr-dependency-version
branch
from
bd7e451 to
04f390e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the env crate dep while simultaneously altering the dep on stellar-xdr used by the macro crate to use a different version than the one brought in by the env dep. This is a hack that's explained in some detail in a comment in the change. It's probably temporary until we come up with something better. cc @leighmcculloch @jonjove
I also added a rust-toolchain.toml to pin us to stable, since I accidentally added a change to the expected diagnostics (and dtolnay is not interested in supporting diagnostics that vary between compilers in trybuild: dtolnay/trybuild#84)