Support Arbitrary #132
Merged
Support Arbitrary #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I commented on stellar/xdrgen#127, let's discuss there. |
|
LGTM! |
leighmcculloch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously this needs to move upstream to xdrgen (I will post a version of the minimal change needed there too) but this is a sketch of what support for
Arbitrarylooks like. Very straightforward -- the only question I think I have is whether @leighmcculloch you'd like it to be cfg'ed behind another feature or not. Argument for feature-cfg'ing is that obviously "it's more code" people might not want to compile; argument against is that "every feature makes a larger powerset".