Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate for overhaul of error codes #258

Merged
merged 1 commit into from
May 17, 2023
Merged

Regenerate for overhaul of error codes #258

merged 1 commit into from
May 17, 2023

Conversation

graydon
Copy link
Contributor

@graydon graydon commented May 14, 2023

This is the companion PR for stellar/stellar-xdr#92 -- changing ScStatus to ScError and reassigning all error codes.

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions inline, but looks good regardless.

src/next/scval_conversions.rs Show resolved Hide resolved
src/next/scval_validations.rs Show resolved Hide resolved
@graydon graydon enabled auto-merge (squash) May 17, 2023 05:33
@graydon graydon merged commit b283ec0 into main May 17, 2023
@graydon graydon deleted the err-reform branch May 17, 2023 05:51
graydon added a commit to stellar/rs-soroban-sdk that referenced this pull request May 19, 2023
This is the companion PR to
stellar/rs-soroban-env#806 (and
stellar/rs-stellar-xdr#258 and
stellar/stellar-xdr#92) overhauling error codes
and renaming Status to Error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants