Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with the serde feature #319

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Nov 7, 2023

What

Shift str impl from the std to alloc feature.

Why

The str was gated behind the std feature, but the str impl is used by the serde feature, and the serde feature is dependent on the alloc feature, not the std feature.

There's no reason to have str gated by std, as it only uses core and alloc dependencies, so gating it behind alloc should be okay. Technically the strkey lib uses std in name hwen it could use alloc. So this change might also require updating strkey to use alloc. But I want to see how far we can get without doing that as updating strkey to not using std will require forking at least one of its dependencies.

@leighmcculloch leighmcculloch marked this pull request as ready for review November 7, 2023 21:15
@leighmcculloch leighmcculloch added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 957273d Nov 7, 2023
@leighmcculloch leighmcculloch deleted the javali-aphanapteryx branch November 7, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants