Fix building with the serde feature #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Shift str impl from the std to alloc feature.
Why
The str was gated behind the std feature, but the str impl is used by the serde feature, and the serde feature is dependent on the alloc feature, not the std feature.
There's no reason to have str gated by std, as it only uses core and alloc dependencies, so gating it behind alloc should be okay. Technically the strkey lib uses std in name hwen it could use alloc. So this change might also require updating strkey to use alloc. But I want to see how far we can get without doing that as updating strkey to not using std will require forking at least one of its dependencies.