-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: directly generate js libs to node_modules #130
base: main
Are you sure you want to change the base?
Conversation
@tyvdh how's this look to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love, but approve, of these changes.
At some point we need a Real NPM Pro™ to assess our jankyness and recommend the best case here. But for now, this is better than what we had and if it works better than what we have I'm all for it.
c9bb315
to
677122f
Compare
|
55b558e
to
d825f43
Compare
@tyvdh the build finally passes 😅 |
Roll back stellar#122, but keep `crowdfund-contract` and `abundance-token` in `optionalDependencies`. As I worked with the old version in earnest, iterating on a local copy of the CLI and generating new JS libs over and over, the two-step generate-to-.soroban, then install-to-node_modules wasn't working very well. Probably because the new library wasn't being added until the `postinstall` step, and the dependencies are optional. Generating directly to `node_modules` feels dirty, but it works consistently. At least in this version, you can still see the dependencies listed in the `optionalDependencies` section, so they're not quite as surprising/mysterious.
Looks like the deps are once again completely absent from |
d825f43
to
b0bebf6
Compare
I just find it hard to believe there isn't a way to handle local packages. How are actual npm packages handling this with CI/CD flows? |
Maybe helpful? |
Good find; trying it out with the latest commit |
9dd26ee
to
b9c3415
Compare
b9c3415
to
ccbae90
Compare
What
Roll back #122, but keep
crowdfund-contract
andabundance-token
inoptionalDependencies
.This also adds a
.gitattributes
to suppresspackage-lock.json
diffs.Why
As I worked with the old version in earnest, iterating on a local copy of the CLI and generating new JS libs over and over, the two-step generate-to-.soroban, then install-to-node_modules wasn't working very well. Probably because the new library wasn't being added until the
postinstall
step, and the dependencies are optional.Generating directly to
node_modules
feels dirty, but it works consistently. At least in this version, compared to the one before #122, you can still see the dependencies listed in theoptionalDependencies
section, so they're not quite as surprising/mysterious.