add option object vec #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,4 +199,18 @@ impl CustomTypesContract { | |||
| pub fn tuple_strukt(_env: Env, tuple_strukt: TupleStruct) -> TupleStruct { | |||
| tuple_strukt | |||
| } | |||
|
|
|||
| pub fn get_object_vec_option(env: Env) -> Option<Vec<Test>> { | |||
There was a problem hiding this comment.
For consistency with other functions in this contract, we should drop the get_ prefix and use the same names as other functions here.
Suggested change
| pub fn get_object_vec_option(env: Env) -> Option<Vec<Test>> { | |
| pub fn option_vec_strukt(env: Env) -> Option<Vec<Test>> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a test case for a js-stellar-sdk issue
Why
When retrieving an Option<Vec> in the sdk you get the following error: TypeError: Type [object Object] was not vec, but [object Object] is
Known limitations
We need to create a separate repo for test vectors but I put this here for now for the sdk bug report.