Add a FIXME for the HTTP request IDs not working

stellar · Apr 17, 2023 · d8ddc47 · d8ddc47
1 parent aad0030
commit d8ddc47
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/cmd/soroban-rpc/internal/jsonrpc.go b/cmd/soroban-rpc/internal/jsonrpc.go
@@ -75,8 +75,9 @@ type rpcLogger struct {
 
 func (r *rpcLogger) LogRequest(ctx context.Context, req *jrpc2.Request) {
 	logger := r.logger.WithFields(log.F{
-		"subsys":   "jsonrpc",
-		"req":      middleware.GetReqID(ctx),
+		"subsys": "jsonrpc",
+		// FIXME: the HTTP request context is independent from the JSONRPC context, and thuse the code below doesn't work
+		// "req":      middleware.GetReqID(ctx),
 		"json_req": req.ID(),
 		"method":   req.Method(),
 	})
@@ -91,7 +92,8 @@ func (r *rpcLogger) LogResponse(ctx context.Context, rsp *jrpc2.Response) {
 	// TODO: Print the elapsed time (there doesn't seem to be a way to it with with jrpc2, since
 	//       LogRequest cannot modify the context)
 	logger := r.logger.WithFields(log.F{
-		"subsys":   "jsonrpc",
+		"subsys": "jsonrpc",
+		// FIXME: the HTTP request context is independent from the JSONRPC context, and thuse the code below doesn't work
 		"req":      middleware.GetReqID(ctx),
 		"json_req": rsp.ID(),
 	})