Address review feedback

stellar · Apr 17, 2023 · f86eac3 · f86eac3
1 parent 3e4d959
commit f86eac3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/cmd/soroban-rpc/internal/daemon/daemon.go b/cmd/soroban-rpc/internal/daemon/daemon.go
@@ -4,7 +4,7 @@ import (
 	"context"
 	"errors"
 	"net/http"
-	_ "net/http/pprof"
+	"net/http/pprof" //nolint:gosec
 	"os"
 	"os/signal"
 	"sync"
@@ -242,8 +242,11 @@ func MustNew(cfg config.LocalConfig, endpoint string, adminEndpoint string) *Dae
 	}
 	if adminEndpoint != "" {
 		adminMux := supporthttp.NewMux(logger)
-		// after importing net/http/pprof, debug endpoints are implicitly registered in the default serve mux
-		adminMux.Handle("/", http.DefaultServeMux)
+		adminMux.HandleFunc("/debug/pprof/", pprof.Index)
+		adminMux.HandleFunc("/debug/pprof/cmdline", pprof.Cmdline)
+		adminMux.HandleFunc("/debug/pprof/profile", pprof.Profile)
+		adminMux.HandleFunc("/debug/pprof/symbol", pprof.Symbol)
+		adminMux.HandleFunc("/debug/pprof/trace", pprof.Trace)
 		adminMux.Handle("/metrics", promhttp.HandlerFor(d.prometheusRegistry, promhttp.HandlerOpts{}))
 		d.adminServer = &http.Server{Addr: adminEndpoint, Handler: adminMux}
 	}

diff --git a/cmd/soroban-rpc/internal/jsonrpc.go b/cmd/soroban-rpc/internal/jsonrpc.go
@@ -85,7 +85,6 @@ func (r *rpcLogger) LogRequest(ctx context.Context, req *jrpc2.Request) {
 	// Params are useful but can be really verbose, let's only print them in debug
 	logger = logger.WithField("params", req.ParamString())
 	logger.Debug("starting JSONRPC request params")
-
 }
 
 func (r *rpcLogger) LogResponse(ctx context.Context, rsp *jrpc2.Response) {