fix: update CLI and tests for new getLedgerEntries #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplifies parsing FullLedgerEntry
tsachiherman
suggested changes
Oct 12, 2023
cmd/soroban-cli/src/rpc/mod.rs
Outdated
| @@ -96,8 +98,8 @@ pub enum Error { | |||
| SpecBase64(#[from] soroban_spec::read::ParseSpecBase64Error), | |||
| #[error("Fee was too large {0}")] | |||
| LargeFee(u64), | |||
| #[error("Failed to parse LedgerEntryData")] | |||
| FailedParseLedgerEntryData, | |||
| #[error("Failed to parse LedgerEntryData\nkey:{0:?}\nvalue:{1:?}\nexpiration:{2:?}")] | |||
There was a problem hiding this comment.
redundant space after the word "parse".
tsachiherman
approved these changes
Oct 12, 2023
tsachiherman
added a commit
that referenced
this pull request
Oct 13, 2023
* Bump Rust and Go dependencies * Start migrating soroban-rpc * Fix get_ledger_changes() invocation * wip migrating the soroban-cli (incomplete!) * Appease rust * Bump core dependencies * Bump Go dependencies again * Fix test comparisons * Fix BumpAndRestoreFootprint test * Improve restore test a bit further * Adjust tests further * Fix typo * Fix GetPreflight test * Get CLI to compile and fix most TODOs * run cargo md-gen * Appease clippy * Add comment about expiration entry efficiency * Address review feedback * Take a stab at extracting the spec from the state * update * linter * limit get_ledger_entries to expiration ledger entries. * fix cli serialization * update test * further fix.. * further fix. * further fix * update test * fix typo * fix: update CLI and tests for new getLedgerEntries (#1021) * fix: add latest_modified_ledger to FullLedgerEntry Also simplifies parsing FullLedgerEntry * fix: CLI test for contract read * fix: update tests to use getLedgerEntries * fix: nit * step * update * fix tests * updating * update per code review --------- Co-authored-by: Alfonso Acosta <alfonso@stellar.org> Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.