feat(CLI): Assembled Transaction that handle preparing transaction post simulation #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
cli/feat/txn_handler
branch
2 times, most recently
from
1ecd504
to
cd165ef
Compare
willemneal
changed the title
willemneal
force-pushed
the
cli/feat/txn_handler
branch
from
cd165ef
to
ea92166
Compare
willemneal
force-pushed
the
cli/feat/txn_handler
branch
4 times, most recently
from
3620f9f
to
8be0e32
Compare
willemneal
requested review from
leighmcculloch
and removed request for
tsachiherman
leighmcculloch
requested review from
2opremio
and removed request for
leighmcculloch
willemneal
force-pushed
the
cli/feat/txn_handler
branch
from
8be0e32
to
9a74b0e
Compare
This renames the `transaction` module to `txn`. Added `txn::Handler` and `txn::State`. The Handler handles the different steps in preparing a transaction to be submitted. From simulation, authentication, and signing. This is the first step in allowing intermediate transactions be returned and used. Also in improving error messages from failed transactions. - [ ] Do not submit transactions that have no auth or writes. We have the data from simulation already.
This makes the logic simpler.
willemneal
force-pushed
the
cli/feat/txn_handler
branch
from
9a74b0e
to
9c18506
Compare
2opremio
approved these changes
Nov 7, 2023
willemneal
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Nov 7, 2023
…st simulation (stellar#1049) * feat(CLI): Transaction Handler that handles the state transitions * fix: assembly transaction after authorizing & improve txn error output * feat: Handler->Assembled - simplify to assembled txn with simulation
willemneal
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Nov 8, 2023
…st simulation (stellar#1049) * feat(CLI): Transaction Handler that handles the state transitions * fix: assembly transaction after authorizing & improve txn error output * feat: Handler->Assembled - simplify to assembled txn with simulation (cherry picked from commit c51c141)
leighmcculloch
pushed a commit
that referenced
this pull request
Nov 9, 2023
…st simulation (#1049) * feat(CLI): Transaction Handler that handles the state transitions * fix: assembly transaction after authorizing & improve txn error output * feat: Handler->Assembled - simplify to assembled txn with simulation (cherry picked from commit 9259e08) Conflicts: cmd/soroban-cli/src/rpc/mod.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
transactionmodule totxn. Addstxn::Assembled.Assembledhandles the different steps in preparing a transaction to be submitted. This is the first step in allowing intermediate transactions be returned and externally signed.Also in improving error messages from failed transactions.