Explicitly supply objectives in Prometheus SummaryOpts #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
approved these changes
Oct 27, 2023
… the updated Prometheus go client
urvisavla
force-pushed
the
prometheus-metrics-fix
branch
from
5c8f2d8
to
4fc7043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR explicitly supplies objectives in Prometheus.SummaryOpts because the new version of the Prometheus go client no longer provides the default value.
Why
In previous versions of the Prometheus go client, default objectives were automatically provided in prometheus.SummaryOpts. However, this was deprecated in version 1.0.0.
Known limitations
N/A