Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make output consistent for all ways to get version #1100

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Make output consistent for all ways to get version #1100

merged 7 commits into from
Nov 28, 2023

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Nov 25, 2023 •
edited
Loading

What

Make output of any way to get at the version consistent.

Why

We should have one version output for folks to provide consistent version info when reporting bugs.

Close #795

@leighmcculloch leighmcculloch marked this pull request as ready for review November 25, 2023 03:19
@leighmcculloch leighmcculloch mentioned this pull request Nov 25, 2023
Closed
@leighmcculloch leighmcculloch enabled auto-merge (squash) November 25, 2023 03:24
@leighmcculloch leighmcculloch changed the title Make only one way to get the version of the CLI Advertise one way to get the version of the CLI Nov 27, 2023
@leighmcculloch leighmcculloch changed the title Advertise one way to get the version of the CLI Advertise one way to get the version of the CLI and make output consistent for all ways Nov 27, 2023
chadoh
chadoh approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leighmcculloch leighmcculloch changed the title Advertise one way to get the version of the CLI and make output consistent for all ways Make output consistent for all ways to get version Nov 27, 2023
@leighmcculloch
Copy link
Member Author

leighmcculloch commented Nov 27, 2023 •
edited
Loading

I pushed a change (not visible on the PR because of GitHub downage) that reduces the change to only making them consistent, and they still get advertised. Because the way to hide the version arg is to define it oureselves and mark it as hidden, but then the clap_markdown dep we use displays hidden args in the docs. I opened an issue about that here:

@leighmcculloch leighmcculloch merged commit db3030a into main Nov 28, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadoh chadoh chadoh approved these changes

@stellarsaur stellarsaur Awaiting requested review from stellarsaur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version, --version, -V, -v weirdness
2 participants
@leighmcculloch @chadoh