Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings-ts): latest RPC & stellar-sdk #1122

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Dec 11, 2023

What

  • update to stellar-sdk@11.0.1
  • fetch expiration using new getFootprint logic
  • improve initialize.sh to show network status
    • latest RPC returns better error messages
    • deal with these and parse getHealth response

Why

current bindings typescript logic is broken with latest Futurenet &
quickstart:soroban-dev

Known limitations

Please double-check my entryRes.entries[0].liveUntilLedgerSeq logic in
the getStorageExpiration function.

@chadoh chadoh requested a review from Shaptic December 11, 2023 21:15
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fixup needed but otherwise :shipit:

Copy link

socket-security bot commented Dec 14, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@typescript-eslint/eslint-plugin 6.10.0...6.14.0 None +17/-16 40.8 MB jameshenry
@typescript-eslint/parser 6.10.0...6.14.0 None +13/-12 37.8 MB jameshenry
@types/node 20.8.5...20.10.4 None +1/-1 4.01 MB types
eslint 8.53.0...8.55.0 None +6/-5 4.37 MB eslintbot
typescript 5.2.2...5.3.3 None +0/-0 32 MB typescript-bot
stellar-sdk 11.0.0-beta.6...11.0.1 None +6/-6 15.6 MB stellar-npm-ci

@mollykarcher mollykarcher added the cli Related to Soroban CLI label Dec 14, 2023
- update to `stellar-sdk@11.0.0`
- fetch expiration using new `getFootprint` logic
- improve `initialize.sh` to show network status
  - latest RPC returns better error messages
  - deal with these and parse `getHealth` response
@chadoh chadoh merged commit 4c41f69 into stellar:main Dec 15, 2023
24 checks passed
@chadoh chadoh deleted the fix/bindings-ts/expiration branch December 15, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to Soroban CLI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants