hot fix v20.0.2, increased preflight instruction fee padding to 3 million #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykarcher
approved these changes
Dec 11, 2023
…tic on resulting fee, it fluctuated alot after increasing the instr budget to 3M
sreuland
commented
Dec 12, 2023
| assert.InDelta(t, uint32(expectedTransactionData.Resources.ReadBytes), uint32(transactionData.Resources.ReadBytes), 10) | ||
| assert.InDelta(t, uint32(expectedTransactionData.Resources.WriteBytes), uint32(transactionData.Resources.WriteBytes), 300) | ||
| assert.InDelta(t, int64(expectedTransactionData.ResourceFee), int64(transactionData.ResourceFee), 3000) | ||
| assert.Greater(t, int64(transactionData.ResourceFee), int64(0)) |
There was a problem hiding this comment.
@tamir, how did you obtain the fee 113910 for this example? after the increase on instr budget to 3M in this pr, the resulting fee here is outside this delta, is the resulting fee deterministic based on other factors, I took a defensive approach on test stability and just assert on minimal aspect of the fee must be > 0, same on line 1124.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
increased the instruction fee padding during preflight to 3 million to accommodate new v20 cost model and more complex contracts that use more compute.
Why
avoid preflight fees failure on contracts that used to work pre-v20
Known limitations
[TODO or N/A]