soroban-rpc: Allow Budget Instruction Leeway to be Configured by Clients #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Dec 14, 2023
2opremio
reviewed
Dec 14, 2023
…rpc-preflight-leeway
…rpc-preflight-leeway
|
Pending updating the SDK to send params as an object so tests will pass |
Shaptic
approved these changes
Dec 15, 2023
Shaptic
approved these changes
Dec 15, 2023
This was referenced Dec 16, 2023
Closed
Closed
Open
Closed
This was referenced Dec 16, 2023
Closed
2opremio
added a commit
to 2opremio/rs-soroban-env
that referenced
this pull request
Jan 15, 2024
1. Backport stellar/stellar-cli#1131 2. Make `ledger_storage` module public
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-env
that referenced
this pull request
Jan 16, 2024
1. Backport stellar/stellar-cli#1131 2. Make `ledger_storage` module public
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR allows budget instruction leeway used in preflight calculations to be configured by passing in a new
ResourceConfigstruct to aSimulateTransactionRequest. Right now we're only allowing the flat addition factor to be configured, but we could add support for both by just adding another field toResourceConfig.If not provided the leeway defaults to what we were previously using (
3000000instructions)NOTE: This PR does not include updating the CLI to support configuring this value through contract command line args.
Why
Preflight estimations have been off, requiring us to repeatedly issue releases to increase the leeway used in these calculations. When users are unable to create contracts due to these issues, there aren't any good workarounds for them.
Closes #1128