Replace cli xdr command with stellar-xdr cli #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2023
|
The dependency sanity checker is erroring in a case where it should be okay to continue. It is displaying this error message:
The version of stellar-xdr used in this repo contains some patches ontop of what core was released with, and those patchers are irrelevant to core and we don't expect core to release a patch for it. The most important dependency to check is the version of the XDR itself, not the version of the stellar-xdr lib. |
stellarsaur
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace cli xdr command with stellar-xdr cli
Why
The stellar-xdr library contains a CLI interface that has more in it than the soroban-cli's xdr command does. Instead of maintaining two, we should just reuse the same CLI within the soroban-cli.
Close #1018