Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: Reduce event memory footprint #1183

Merged
merged 1 commit into from
Jan 31, 2024
Merged

rpc: Reduce event memory footprint #1183

merged 1 commit into from
Jan 31, 2024

Conversation

2opremio
Copy link
Contributor

  1. Get rid of the in-memory operation index (since it was always set to zero anyways)
  2. Keep events serialized while in memory (it saves quite a bit of space due to the inneficient representation of unions in golang).

@2opremio
rpc: Reduce event memory footprint
6c393c5 
1. Get rid of the in-memory operation index (since it was always set to zero anyways)
2. Keep events serialized while in memory (it saves quite a bit of space due to the inneficient representation of unions in golang).
Shaptic
Shaptic approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice! 👏 are there benchmarks? not that they're necessary to merge by any means but it'd be cool to see what kind of improvement this adds

@2opremio
Copy link
Contributor Author

@psheth9 is working on the benchmarks separately

@2opremio 2opremio merged commit 433cd44 into stellar:main Jan 31, 2024
25 checks passed
@2opremio 2opremio deleted the rpc-reduce-event-memory branch January 31, 2024 10:05
@2opremio 2opremio mentioned this pull request Jan 31, 2024
Merged
2opremio added a commit that referenced this pull request Mar 26, 2024
@2opremio @stellarsaur
rpc: Reduce event memory footprint (#1183)
e900585 
1. Get rid of the in-memory operation index (since it was always set to zero anyways)
2. Keep events serialized while in memory (it saves quite a bit of space due to the inneficient representation of unions in golang).

(cherry picked from commit 433cd44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

@tamirms tamirms Awaiting requested review from tamirms

@sreuland sreuland Awaiting requested review from sreuland

@aditya1702 aditya1702 Awaiting requested review from aditya1702

@psheth9 psheth9 Awaiting requested review from psheth9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2opremio @Shaptic